sqlite: expose prepared statement statistics#64541
Open
geeksilva97 wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
geeksilva97
force-pushed
the
sqlite-statement-statistics
branch
2 times, most recently
from
July 16, 2026 18:42
f5e8fcb to
2195e97
Compare
geeksilva97
marked this pull request as ready for review
July 16, 2026 18:43
Contributor
|
I'm a little uncomfortable with getters that create an object every time they're read. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64541 +/- ##
=======================================
Coverage 90.23% 90.23%
=======================================
Files 739 739
Lines 241744 241770 +26
Branches 45552 45572 +20
=======================================
+ Hits 218136 218161 +25
- Misses 15148 15154 +6
+ Partials 8460 8455 -5
🚀 New features to boost your workflow:
|
geeksilva97
force-pushed
the
sqlite-statement-statistics
branch
2 times, most recently
from
July 16, 2026 21:12
bbbbeec to
bef2511
Compare
araujogui
reviewed
Jul 16, 2026
| {"run", SQLITE_STMTSTATUS_RUN}, | ||
| {"filterMiss", SQLITE_STMTSTATUS_FILTER_MISS}, | ||
| {"filterHit", SQLITE_STMTSTATUS_FILTER_HIT}, | ||
| {"memused", SQLITE_STMTSTATUS_MEMUSED}, |
Member
There was a problem hiding this comment.
Suggested change
| {"memused", SQLITE_STMTSTATUS_MEMUSED}, | |
| {"memUsed", SQLITE_STMTSTATUS_MEMUSED}, |
Contributor
There was a problem hiding this comment.
Since SQLite does not use an underscore here, I think memused is a more faithful name to the SQLite API.
Contributor
Author
There was a problem hiding this comment.
yeah, that was the pattern followed
Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com>
geeksilva97
force-pushed
the
sqlite-statement-statistics
branch
from
July 17, 2026 16:25
bef2511 to
fd5654c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #64540